Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework player state handling in the frontend #122

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Flova
Copy link
Member

@Flova Flova commented Feb 22, 2021

This pr closes #22.
We are not able to distinguish between a user interaction and an incomming new state. We thought that was an issue, but in the real live it was not an issue, because the watch on the state only triggers if the state differs from the old state and not if an state is set. Therefore our flags introduced the bug instead of preventing it. Also the state was only set to the player on state changes, BUT it was sent out every time it updates (also if it stays the same) to all other ones. This in combination with the unused seconds offset resulted in the jitter that was observed before our last "fix". We also need to be careful that we don't update a state twice at once because e.g. the pause and seconds changed. But this should also be fixed now. Yay.

@Flova Flova requested a review from timonegk February 22, 2021 21:09
@jaagut jaagut self-requested a review April 29, 2021 09:32
@timonegk timonegk removed their request for review July 15, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sync fails some times
1 participant